New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fallback pager in log command to tail -n 50 #10755

Merged
merged 2 commits into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@wvu-r7
Contributor

wvu-r7 commented Oct 5, 2018

This addresses concerns @busterb and I had over log not displaying a full stack trace.

  • Test the edit command
    • Test when LocalEditor is set as a global option
    • Test the $VISUAL and $EDITOR environment variables
    • Test when vim or vi is in your $PATH
    • Test the fallback editor
  • Test the log command
    • Test when LocalPager is set as a global option
    • Test the $PAGER and $MANPAGER environment variables
    • Test when less or more is in your $PATH
    • Test the fallback "pager"

#10664

Bump fallback pager in log command to tail -n 50
24 is never enough. Unless you're Jack Bauer.

(The 24 comes from the VT100. :)

@busterb busterb merged commit 938139d into rapid7:master Oct 5, 2018

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

busterb added a commit that referenced this pull request Oct 5, 2018

msjenkins-r7 added a commit that referenced this pull request Oct 5, 2018

@wvu-r7

This comment has been minimized.

Show comment
Hide comment
@wvu-r7

wvu-r7 Oct 5, 2018

Contributor

Release Notes

This increases the number of lines the fallback "pager" in the log command outputs from 24 to 50 in order to handle longer stack traces. Additionally, vim/vi and less/more are checked for before using the fallback editor or pager.

Contributor

wvu-r7 commented Oct 5, 2018

Release Notes

This increases the number of lines the fallback "pager" in the log command outputs from 24 to 50 in order to handle longer stack traces. Additionally, vim/vi and less/more are checked for before using the fallback editor or pager.

@wvu-r7

This comment has been minimized.

Show comment
Hide comment
@wvu-r7

wvu-r7 Oct 5, 2018

Contributor

Thanks, bruv.

Contributor

wvu-r7 commented Oct 5, 2018

Thanks, bruv.

@wvu-r7 wvu-r7 deleted the wvu-r7:bug/log branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment