New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webcam_stream full path to console #10770

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
3 participants
@h00die
Contributor

h00die commented Oct 8, 2018

webcam_snap displays the full path in output, which is convenient for opening manually.
webcam_stream only displays the file name, not the full path, which can be confusing to new users. Is that file on my local drive, on 127.0.0.1:?/<file>, on the bind/local port for meterp?

This PR prints the full path to clarify.

Pre Patch

meterpreter > webcam_snap
[*] Starting...
[+] Got frame
[*] Stopped
Webcam shot saved to: /my/fake/path/metasploit-framework/ERVxTvUh.jpeg
meterpreter > webcam_stream
[*] Starting...
[*] Preparing player...
[*] Opening player at: qMSkblpS.html
[*] Streaming...

Post Patch

meterpreter > webcam_stream
[*] Starting...
[*] Preparing player...
[*] Opening player at: /my/fake/path/metasploit-framework/ItRfELto.html
[*] Streaming...
^C[-] Error running command webcam_stream: Interrupt 
meterpreter > webcam_stream -v false
[*] Starting...
[*] Preparing player...
[*] Please open the player manually with a browser: /my/fake/path/metasploit-framework/kIdIEEaB.html
[*] Streaming...

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • get a meterp
  • webcam_stream
  • Verify the full path is printed
@h00die

This comment has been minimized.

Show comment
Hide comment
@h00die

h00die Oct 9, 2018

Contributor

@timwr or anyone else, I believe webcam_snap (at a minimum) isn't databased as loot. I would think that would be a good idea to help keep track of which .jpeg came from which session/host with out having to refer back to the logs.
Any history or insight on why this is the way it is?

Contributor

h00die commented Oct 9, 2018

@timwr or anyone else, I believe webcam_snap (at a minimum) isn't databased as loot. I would think that would be a good idea to help keep track of which .jpeg came from which session/host with out having to refer back to the logs.
Any history or insight on why this is the way it is?

@busterb

This comment has been minimized.

Show comment
Hide comment
@busterb

busterb Oct 9, 2018

Contributor

@h00die my hunch would be just a simple oversight. It would be nice to make it work with the loot system

Contributor

busterb commented Oct 9, 2018

@h00die my hunch would be just a simple oversight. It would be nice to make it work with the loot system

@busterb busterb merged commit 71a6d80 into rapid7:master Oct 9, 2018

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

busterb added a commit that referenced this pull request Oct 9, 2018

@busterb

This comment has been minimized.

Show comment
Hide comment
@busterb

busterb Oct 9, 2018

Contributor

Release Notes

The webcam_stream command in Meterpreter now prints the full path to the client viewer file.

Contributor

busterb commented Oct 9, 2018

Release Notes

The webcam_stream command in Meterpreter now prints the full path to the client viewer file.

msjenkins-r7 added a commit that referenced this pull request Oct 9, 2018

@h00die h00die deleted the h00die:stream_path branch Oct 10, 2018

@h00die

This comment has been minimized.

Show comment
Hide comment
@h00die

h00die Oct 10, 2018

Contributor

looks like it was in the post module, just not the command dispatcher:

Contributor

h00die commented Oct 10, 2018

looks like it was in the post module, just not the command dispatcher:

@h00die

This comment has been minimized.

Show comment
Hide comment
@h00die

h00die Oct 10, 2018

Contributor

seems only windows has a webcam post module... ive been testing android, which may explain why i was looking at the command dispatcher

Contributor

h00die commented Oct 10, 2018

seems only windows has a webcam post module... ive been testing android, which may explain why i was looking at the command dispatcher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment