New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpc shell read fix #10781

Merged
merged 2 commits into from Oct 10, 2018

Conversation

Projects
None yet
3 participants
@ivonutar
Contributor

ivonutar commented Oct 10, 2018

This fixes the bug from allfro/pymetasploit#21. When using rpc sessions (eg. in pymetasploit python module), error was thrown because rpc_shell_read was basically a copy of rpc_shell_write function.

Verification

List the steps needed to make sure this thing works

  • Start msfrpcd
  • Use pymetasploit python module to open a RPC session
  • Try to read data from session
  • Verify that no error is thrown ( metasploit.msfrpc.MsfRpcError: Session Disconnected: NameError undefined local variable or method `data' for #Msf::RPC::RPC_Session:0x000055f37858e398
    )

@busterb busterb self-assigned this Oct 10, 2018

@busterb

This comment has been minimized.

Show comment
Hide comment
@busterb

busterb Oct 10, 2018

Contributor

Thanks, checking it out now.

Contributor

busterb commented Oct 10, 2018

Thanks, checking it out now.

@ivonutar

This comment has been minimized.

Show comment
Hide comment
@ivonutar

ivonutar Oct 10, 2018

Contributor

Sorry for not including more detailed steps for the bug verification, but, considering the triviality of the bug (basically a typo), I do not find it very important :) Of course, I can attach it, if needed.

Contributor

ivonutar commented Oct 10, 2018

Sorry for not including more detailed steps for the bug verification, but, considering the triviality of the bug (basically a typo), I do not find it very important :) Of course, I can attach it, if needed.

@busterb

This comment has been minimized.

Show comment
Hide comment
@busterb

busterb Oct 10, 2018

Contributor

That's alright. I'm familiar with the code since I probably introduced the bug!

Contributor

busterb commented Oct 10, 2018

That's alright. I'm familiar with the code since I probably introduced the bug!

@busterb busterb merged commit 50755b2 into rapid7:master Oct 10, 2018

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

busterb added a commit that referenced this pull request Oct 10, 2018

msjenkins-r7 added a commit that referenced this pull request Oct 10, 2018

@busterb

This comment has been minimized.

Show comment
Hide comment
@busterb

busterb Oct 10, 2018

Contributor

Release Notes

This fixes an error in the Metasploit RPC handler for reading data from a session.

Contributor

busterb commented Oct 10, 2018

Release Notes

This fixes an error in the Metasploit RPC handler for reading data from a session.

@gdavidson-r7 gdavidson-r7 added the rn-fix label Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment