New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unknown author mapping in author.rb #10787

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
2 participants
@wvu-r7
Contributor

wvu-r7 commented Oct 10, 2018

No one was using it and instead writing "Unknown" directly. It was also producing an invalid e-mail address.

Lazy grep:

wvu@kharak:~/metasploit-framework:bug/author$ git grep -A 10 Author modules | grep -w anonymous
modules/auxiliary/scanner/ftp/anonymous.rb:      'Author'      => 'Matteo Cantoni <goony[at]nothink.org>',
modules/auxiliary/scanner/ftp/anonymous.rb-      'License'     => MSF_LICENSE
modules/auxiliary/scanner/ftp/anonymous.rb-    )
modules/auxiliary/scanner/ftp/anonymous.rb-
modules/auxiliary/scanner/ftp/anonymous.rb-    register_options(
modules/auxiliary/scanner/ftp/anonymous.rb-      [
modules/auxiliary/scanner/ftp/anonymous.rb-        Opt::RPORT(21),
modules/auxiliary/scanner/ftp/anonymous.rb-      ])
modules/auxiliary/scanner/ftp/anonymous.rb-  end
modules/auxiliary/scanner/ftp/anonymous.rb-
modules/auxiliary/scanner/ftp/anonymous.rb-  def run_host(target_host)
wvu@kharak:~/metasploit-framework:bug/author$ git grep -A 10 Author modules | grep -wc Unknown
113
wvu@kharak:~/metasploit-framework:bug/author$

Happy to change this if we have a better approach.

#10672 (comment)

@wvu-r7 wvu-r7 requested a review from busterb Oct 10, 2018

@wvu-r7 wvu-r7 closed this Oct 10, 2018

@wvu-r7 wvu-r7 changed the title from Update unknown author constant and comment to Remove unknown author mapping in author.rb Oct 10, 2018

@wvu-r7 wvu-r7 reopened this Oct 10, 2018

Remove unknown author mapping in author.rb
No one was using it and instead writing "Unknown" directly. It was also
producing an invalid e-mail address.

@wvu-r7 wvu-r7 removed the request for review from busterb Oct 10, 2018

@wvu-r7

This comment has been minimized.

Show comment
Hide comment
@wvu-r7

wvu-r7 Oct 10, 2018

Contributor

Sorry for the chaotic PR. Brain isn't working this morning. This should be good to go once the tests pass (I verified they test this case).

Contributor

wvu-r7 commented Oct 10, 2018

Sorry for the chaotic PR. Brain isn't working this morning. This should be good to go once the tests pass (I verified they test this case).

@busterb busterb self-assigned this Oct 10, 2018

@busterb busterb merged commit 63bcbdc into rapid7:master Oct 10, 2018

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

busterb added a commit that referenced this pull request Oct 10, 2018

msjenkins-r7 added a commit that referenced this pull request Oct 10, 2018

@busterb

This comment has been minimized.

Show comment
Hide comment
@busterb

busterb Oct 10, 2018

Contributor

For the record, this doesn't mean 'Unknown' authors are disallowed, just that the best way is to simply say 'Unknown' right in the module.

Contributor

busterb commented Oct 10, 2018

For the record, this doesn't mean 'Unknown' authors are disallowed, just that the best way is to simply say 'Unknown' right in the module.

@wvu-r7 wvu-r7 deleted the wvu-r7:bug/author branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment