New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `writable?` method for local modules #10910

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@bcoles
Contributor

bcoles commented Nov 4, 2018

Updates various Linux and OSX local exploit modules to make use of the new Msf::Post::File.writable? method added in #10644 rather than manually checking the output of test -w /path.

Also moves WritableDir from register_options to register_advanced_options for a few modules which were missed in #10783.

@bcoles bcoles added the easy label Nov 4, 2018

@Green-m Green-m self-assigned this Nov 5, 2018

@Green-m

This comment has been minimized.

Contributor

Green-m commented Nov 5, 2018

LGTM, don't know why the Sanity Test Execution failed.

@Green-m Green-m merged commit c3080d6 into rapid7:master Nov 5, 2018

2 of 3 checks passed

Metasploit Automation - Sanity Test Execution Failed to pass tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Green-m added a commit that referenced this pull request Nov 5, 2018

msjenkins-r7 added a commit that referenced this pull request Nov 5, 2018

@bcoles bcoles deleted the bcoles:use_writable_method branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment