Join GitHub today
add encoders module : msf > set ruby/base32 #10921
Tell us what this change does. If you're fixing a bug, please mention
List the steps needed to make sure this thing works
Also, this clearly hasn't been tested.
Also, what does the base32 encoder offer over the base64 encoder?
Also, the comment header is malformed.
This module requires Metasploit: https://metasploit.com/download # Current source: https://github.com/rapid7/metasploit-framework ##
Should be this:
## # This module requires Metasploit: https://metasploit.com/download # Current source: https://github.com/rapid7/metasploit-framework ##
Please also run msftidy on this, as it is failing because of:
You can find msftidy in the tools/dev directory and run it manually before pushing your changes to verify they are correct.
If you are new to Ruby, please also check out Rubocop: https://github.com/rapid7/metasploit-framework/wiki/Using-Rubocop
Hi there @ismailtasdelen! Sorry if that was confusing. We have different people coming and helping us out, so sometimes we can be a bit quick in our answers. I'd be happy to help with this, so please feel free to ask- you can be sure that I get it by adding
I see you got some of the changes from @bcoles done, and that's great. His comment about master was that you have pushed up your master branch rather than a topic branch. The catch there is that you will likely keep using your master branch, so in the future, we will not be able to compare the code well. You can read more and see an example of why we don't want that to happen here: https://github.com/rapid7/metasploit-framework/blob/master/CONTRIBUTING.md
The EOL errors from msftidy are because the line endings in the file are in Windows style instead of Unix. That's easy to fix, but usually it depends on the editor or the OS you are using. In Linux, you could use
It would also help if you took a few lines to tell us why you want to add this. I am not totally an expert at encoders and why I might use one over another, so in this case, is there a situation you found that this to succeed when our current encoders fail? I'm also fine if this is just faster/better/more extensible. It just helps us to know why this helps out users.
This is a Base64 decoder, not a Base32 decoder.
It is required that code in your fork be merged from a unique branch in your repository to master in Rapid7's. Please create a new branch in your fork of framework and resubmit this from that branch.
This helps protect the process, ensure users are aware of commits on the branch being considered for merge, allows for a location for more commits to be offered without mingling with other contributor changes and allows contributors to make progress while a PR is still being reviewed.
Closing based on the this requirement, please do resubmit from a unique branch.