New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename `hash` to `generate_process_hash` #10924

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@jmartin-r7
Contributor

jmartin-r7 commented Nov 5, 2018

In the interest of compatibility this uses a more descriptive name for
the process hash creation method instead of overriding ruby's hash method.
See https://docs.ruby-lang.org/en/2.0.0/Hash.html

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use exploits/windows/smb/ms17_010_eternalblue
    ...
  • Verify it works still
Rename `hash` to `generate_process_hash`
In the interest of compatibility this uses a more descriptive name for
the process hash creation method instead of overriding ruby's hash method.
See https://docs.ruby-lang.org/en/2.0.0/Hash.html
@wvu-r7

This comment has been minimized.

Contributor

wvu-r7 commented Nov 5, 2018

Eerily similar to #6957.

@wvu-r7 wvu-r7 self-assigned this Nov 5, 2018

@wvu-r7 wvu-r7 added module bug labels Nov 5, 2018

wvu-r7 added a commit to wvu-r7/metasploit-framework that referenced this pull request Nov 5, 2018

@wvu-r7 wvu-r7 merged commit dd57b27 into rapid7:master Nov 5, 2018

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jmartin-r7 jmartin-r7 deleted the jmartin-r7:rename_method_generate_process_hash branch Nov 5, 2018

msjenkins-r7 added a commit that referenced this pull request Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment