New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CentOS and Alpine Linux detection to Linux system lib #10927

Merged
merged 1 commit into from Nov 10, 2018

Conversation

Projects
None yet
3 participants
@bcoles
Contributor

bcoles commented Nov 6, 2018

Add CentOS and Alpine Linux detection to Msf::Post::Linux::System.get_sysinfo


CentOS

Before

Hosts
=====

address         mac  name                       os_name  os_flavor                             os_sp  purpose  info  comments
-------         ---  ----                       -------  ---------                             -----  -------  ----  --------
123.45.67.141        centos-7-1708.localdomain  amazon   CentOS Linux release 7.4.1708 (Core)                         

After

Hosts
=====

address         mac  name                       os_name  os_flavor                             os_sp  purpose  info  comments
-------         ---  ----                       -------  ---------                             -----  -------  ----  --------
123.45.67.141        centos-7-1708.localdomain  centos   CentOS Linux release 7.4.1708 (Core)          server         

Alpine Linux

Before

Hosts
=====

address         mac  name       os_name  os_flavor                                         os_sp  purpose  info  comments
-------         ---  ----       -------  ---------                                         -----  -------  ----  --------
123.45.67.123        localhost  linux    Welcome to Alpine Linux 3.8Kernel \r on an \m ()                        

After

Hosts
=====

address         mac  name       os_name  os_flavor  os_sp  purpose  info  comments
-------         ---  ----       -------  ---------  -----  -------  ----  --------
123.45.67.123        localhost  alpine   3.8.1                            

@h00die h00die self-assigned this Nov 6, 2018

@wvu-r7

This comment has been minimized.

Contributor

wvu-r7 commented Nov 6, 2018

Did we ever add os-release checking? I think that might be a useful enhancement.

@bcoles bcoles added the bug label Nov 7, 2018

@h00die

This comment has been minimized.

Contributor

h00die commented Nov 10, 2018

so much amazon.

msf5 post(linux/gather/enum_system) > hosts

Hosts
=====

address        mac  name  os_name  os_flavor                         os_sp  purpose  info  comments
-------        ---  ----  -------  ---------                         -----  -------  ----  --------
1.1.1.1             amazon   CentOS Linux release 6.0 (Final)                        

so much centos

msf5 post(linux/gather/enum_system) > hosts

Hosts
=====

address        mac  name  os_name  os_flavor                         os_sp  purpose  info  comments
-------        ---  ----  -------  ---------                         -----  -------  ----  --------
1.1.1.1             centos   CentOS Linux release 6.0 (Final)                        
@h00die

This comment has been minimized.

Contributor

h00die commented Nov 10, 2018

alpine

msf5 post(linux/gather/enum_system) > hosts

Hosts
=====

address        mac  name  os_name  os_flavor                         os_sp  purpose  info  comments
-------        ---  ----  -------  ---------                         -----  -------  ----  --------
2.2.2.2             alpine   3.8.1                                                   

@h00die h00die merged commit 08d4e22 into rapid7:master Nov 10, 2018

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

h00die added a commit that referenced this pull request Nov 10, 2018

@h00die

This comment has been minimized.

Contributor

h00die commented Nov 10, 2018

Release Notes

This fixes a linux post library bug that identified CentOS as amazon.

@bcoles bcoles deleted the bcoles:lib-post-linux-system branch Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment