New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem reporting website: opts must include a valid :workspace. #11043

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@exenin

exenin commented Nov 30, 2018

@bcoles

This comment has been minimized.

Contributor

bcoles commented Dec 2, 2018

It is required that code in your fork be merged from a unique branch in your repository to master in Rapid7's. Please create a new branch in your fork of framework and resubmit this from that branch.

git checkout -b <BRANCH_NAME>
git push <your_fork_remote> <BRANCH_NAME>

This helps protect the process, ensure users are aware of commits on the branch being considered for merge, allows for a location for more commits to be offered without mingling with other contributor changes and allows contributors to make progress while a PR is still being reviewed.

Closing based on the this requirement, please do resubmit from a unique branch.

@bcoles bcoles closed this Dec 2, 2018

@@ -1416,7 +1416,7 @@ def process_urls(urlstr)
end
#print_status "aaa"
#print_status framework.db.workspace.name
print_status framework.db.workspace.name

This comment has been minimized.

@bcoles

bcoles Dec 2, 2018

Contributor

Was this uncommenting intentional?

This comment has been minimized.

@threedr3am

threedr3am Dec 7, 2018

Excuseme,the problem how to slove?

This comment has been minimized.

@threedr3am

threedr3am Dec 7, 2018

I pull head master now.But,this problem not slove.

@bcoles

This comment has been minimized.

Contributor

bcoles commented Dec 7, 2018

@exenin are you keen to submit a new PR? Alternatively, we can take care of patching the issue. I've verified your patch works as described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment