New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add realm info to creds doc #11056

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@jbarnett-r7
Contributor

jbarnett-r7 commented Dec 3, 2018

This PR adds missing information for Realm objects to the Metasploit Credential API doc.

Verification

List the steps needed to make sure this thing works

  • Start the webservice msfdb start --component webservice
  • In a browser, navigate to https://localhost:8080/api/v1/api-docs
  • Read over the changes to the Credential model and Realm model and ensure they look correct

@jbarnett-r7 jbarnett-r7 added the msf5 label Dec 3, 2018

@ebleiweiss-r7 ebleiweiss-r7 merged commit 23bbe72 into rapid7:master Dec 3, 2018

2 checks passed

Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ebleiweiss-r7 added a commit that referenced this pull request Dec 3, 2018

@ebleiweiss-r7 ebleiweiss-r7 requested review from ebleiweiss-r7 and removed request for ebleiweiss-r7 Dec 3, 2018

@ebleiweiss-r7

This comment has been minimized.

Contributor

ebleiweiss-r7 commented Dec 3, 2018

Release Notes

This adds definitions for Realm objects to the Credential model in the data service API docs

@ebleiweiss-r7 ebleiweiss-r7 self-assigned this Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment