New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nuuo_nvrmini_upgrade_rce.rb #11072

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@berkdsnr

berkdsnr commented Dec 6, 2018

Tell us what this change does. If you're fixing a bug, please mention
the github issue number.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use exploit/windows/smb/ms08_067_netapi
  • ...
  • Verify the thing does what it should
  • Verify the thing does not do what it should not
  • Document the thing and how it works (Example)
@berkdsnr

This comment has been minimized.

@berkdsnr

This comment has been minimized.

berkdsnr commented Dec 6, 2018

Can you review it again

@bcoles bcoles referenced this pull request Dec 6, 2018

Closed

nuuo_nvrmini_upgrade_rce #11069

0 of 6 tasks complete
@bcoles

This comment has been minimized.

Contributor

bcoles commented Dec 6, 2018

Please resolve msftidy errors.

$ ./.git/hooks/post-merge
[*] Running msftidy.rb in ./.git/hooks/post-merge mode
--- Checking new and changed module syntax with tools/dev/msftidy.rb ---
modules/exploits/multi/http/nuuo_nvrmini_upgrade_rce.rb:20 - [WARNING] Spaces at EOL

berkdsnr added some commits Dec 6, 2018

berkdsnr added some commits Dec 6, 2018

fail_with(Failure::Unknown, 'Failed to execute the command.')
end
res
end

This comment has been minimized.

@bcoles

bcoles Dec 6, 2018

Contributor
Suggested change Beta
end
end

This comment has been minimized.

@berkdsnr

This comment has been minimized.

@bcoles

bcoles Dec 6, 2018

Contributor

No it isn't

indentation

end
res
end
def exploit

This comment has been minimized.

@bcoles

bcoles Dec 6, 2018

Contributor
Suggested change Beta
def exploit
def exploit

This comment has been minimized.

@berkdsnr

This comment has been minimized.

@bcoles

bcoles Dec 6, 2018

Contributor

No it isn't

indentation

end
def exploit
http_send_command(payload.encoded)
end

This comment has been minimized.

@bcoles

bcoles Dec 6, 2018

Contributor
Suggested change Beta
end
end

This comment has been minimized.

@berkdsnr

This comment has been minimized.

@bcoles

bcoles Dec 6, 2018

Contributor

No it isn't

indentation

def exploit
http_send_command(payload.encoded)
end
end

This comment has been minimized.

@bcoles

bcoles Dec 6, 2018

Contributor
Suggested change Beta
end
end

This comment has been minimized.

@berkdsnr

This comment has been minimized.

@bcoles

bcoles Dec 6, 2018

Contributor

No it isn't

indentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment