New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax in "badpdf" module #11216

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@cnotin
Copy link
Contributor

cnotin commented Jan 9, 2019

Fixes a bug in the badpdf module with single quotes used in a single quotes string which is a syntax error

Quick bug repro

  • launch msfconsole
  • use auxiliary/fileformat/badpdf
  • set LHOST 127.0.0.1
  • run
    Will trigger:
[-] Auxiliary failed: NoMethodError undefined method `pdf' for "FILENAME or PDFINJECT must end with ":String
[-] Call stack:
[-]   /usr/share/metasploit-framework/modules/auxiliary/fileformat/badpdf.rb:49:in `run'

With fix applied

msf auxiliary(fileformat/badpdf) > run

[-] FILENAME or PDFINJECT must end with '.pdf' file extension

@cnotin cnotin changed the title badpdf: fix syntax Fix syntax in "badpdf" module Jan 9, 2019

@cnotin

This comment has been minimized.

Copy link
Contributor

cnotin commented Jan 9, 2019

Made redundant by #11217

@cnotin cnotin closed this Jan 9, 2019

@cnotin cnotin deleted the cnotin:patch-1 branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment