New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont log every request when using HTTP data service #11225

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@jbarnett-r7
Copy link
Contributor

jbarnett-r7 commented Jan 10, 2019

This PR disables a log line that prints out every HTTP request made to framework.log when connected to an HTTP data service. This log line was specified as a debug log line, but it was unclear when it was added that framework's log levels don't actually affect the amount of logging that gets saved.

We should definitely re-enable this logging as it is very useful for development, but not until true log levels are honored as it can become very verbose.

Note that errors will still generate log lines.

Verification

  • Start msfconsole
  • Connect to an HTTP data service
  • Generate some activity by running various DB related commands such as host -a 172.1.2.3, loot -a -f /path/to/file.txt -i testfile -t text 172.4.5.6, and hosts.
  • Check the file at ~/.msf4/logs/framework.log and ensure log entries are not created for these requests.
  • Generate an error when communicating with the HTTP data service. Ensure that the error messages are still logged.

@busterb busterb added the msf5 label Jan 10, 2019

@busterb busterb self-assigned this Jan 10, 2019

@busterb busterb merged commit 4074913 into rapid7:master Jan 10, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

busterb added a commit that referenced this pull request Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment