New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to return all keys instead of first key in memcached_extractor.rb #11227

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jeswinMathai
Copy link

jeswinMathai commented Jan 10, 2019

There is a parsing issue with the data returned by the Memcached server. Variable data contains information regarding all keys. But since match function is used, only the first matched string is being stored in the keys array. For parsing all the key names from the data, scan function was used instead of match.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use auxiliary/gather/memcached_extractor
  • set RHOSTS 192.168.1.5
  • exploit
Fix to return all keys instead of first key.
match function was only returning the first matched string as a result only the first key was returned and the rest of the keys were not getting processed.
@jrobles-r7

This comment has been minimized.

Copy link
Contributor

jrobles-r7 commented Jan 15, 2019

It is required that code in your fork be merged from a unique branch in your repository to master in Rapid7's. Please create a new branch in your fork of framework and resubmit this from that branch.

git checkout -b <BRANCH_NAME>
git push <your_fork_remote> <BRANCH_NAME>

This helps protect the process, ensure users are aware of commits on the branch being considered for merge, allows for a location for more commits to be offered without mingling with other contributor changes and allows contributors to make progress while a PR is still being reviewed.

Closing based on the this requirement, please do resubmit from a unique branch.

@jrobles-r7 jrobles-r7 closed this Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment