New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move msfdb_ws to tools/dev since it is deprecated by msfdb #11228

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@mkienow-r7
Copy link
Contributor

mkienow-r7 commented Jan 10, 2019

Moves the msfdb_ws script to tools/dev since it is deprecated by the msfdb script. It is important to note that the functional remote data service spec tests currently utilize the msfdb_ws script to host the Metasploit data web service. Once we rework the test code we should be able to remove the msfdb_ws script completely.

Tickets: MS-3702, MS-3701

Verification

  • Ensure you do not have the Metasploit data web service started via msfdb, ./msfdb status. If it is currently running stop it with ./msfdb --component webservice stop.
  • Start ./tools/dev/msfdb_ws
  • Verify msfdb_ws behaves as before, serving the Metasploit data web service and that API endpoints operate as expected
  • Press Ctrl-C to terminate msfdb_ws
  • Run spec tests with remote database testing enabled: REMOTE_DB=1 bundle exec rake spec
  • Run spec tests without remote database testing enabled: bundle exec rake spec
  • Verify both sets of tests run successfully. With one exception, there currently appears to be 5 creds related tests that fail when remote database testing enabled. These should be address in a separate PR as it is unrelated to these changes.

mkienow-r7 added some commits Jan 10, 2019

Update Rspec expected thread count
When REMOTE_DB is set there is a thread for the web service, in
addition to the External modules thread manager, so there is one or two
threads by the end of the test run in addition to the main VM thread.

@mkienow-r7 mkienow-r7 added the msf5 label Jan 10, 2019

@busterb busterb self-assigned this Jan 10, 2019

@busterb

This comment has been minimized.

Copy link
Contributor

busterb commented Jan 10, 2019

Glad you caught the missing test runs during this!

@busterb busterb merged commit c3f71a1 into rapid7:master Jan 10, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

busterb added a commit that referenced this pull request Jan 10, 2019

@mkienow-r7 mkienow-r7 deleted the mkienow-r7:MS-3702-move-msfdb-ws-to-tools branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment