New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict sqlite3 gem for windows #11362

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@jmartin-r7
Copy link
Contributor

jmartin-r7 commented Feb 5, 2019

Restrict sqlite3 gem until a released pre-compiled gem is available.
With the release of sqlite3 1.4.0 a pre-compiled gem has not yet been deployed. In the interest of supporting windows nightly builds, this restricts the bundle to ~>1.3 to pickup the OS specific gems for the time being.

https://rubygems.org/gems/sqlite3/
https://github.com/sparklemotion/sqlite3-ruby

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • play with something that exercises sqlite3 ¯\(ツ)

@acammack-r7 acammack-r7 self-assigned this Feb 5, 2019

@acammack-r7 acammack-r7 merged commit fb7ddeb into rapid7:master Feb 5, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

acammack-r7 added a commit that referenced this pull request Feb 5, 2019

jmartin-r7 added a commit that referenced this pull request Feb 6, 2019

@jmartin-r7 jmartin-r7 deleted the jmartin-r7:restrict_sqlite3 branch Feb 6, 2019

@jmartin-r7 jmartin-r7 referenced this pull request Feb 6, 2019

Merged

lock sqlite3 to compatible minor not just major #11363

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment