Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced winrm_cmd module #11445

Merged
merged 2 commits into from Feb 28, 2019

Conversation

Projects
None yet
5 participants
@Yashvendra
Copy link
Contributor

Yashvendra commented Feb 21, 2019

This PR solves the issue #11440

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use auxiliary/scanner/winrm/winrm_cmd.rb
  • set RHOSTS [IP]
  • set USERNAME [USERNAME]
  • set PASSWORD [PASSWORD]
  • set CMD [WINDOWS COMMAND]
  • run

@h00die h00die self-assigned this Feb 21, 2019

@Yashvendra

This comment has been minimized.

Copy link
Contributor Author

Yashvendra commented Feb 28, 2019

Why is it taking so much time to complete the checking, its been 2 days.

@bcoles

This comment has been minimized.

Copy link
Contributor

bcoles commented Feb 28, 2019

Why is it taking so much time to complete the checking, its been 2 days.

It's fine. The tests passed. GitHub doesn't realise for some reason.

@bcoles

This comment has been minimized.

Copy link
Contributor

bcoles commented Feb 28, 2019

@msjenkins-r7 test this please

@busterb busterb self-assigned this Feb 28, 2019

@busterb busterb merged commit 31bf6a1 into rapid7:master Feb 28, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details

busterb added a commit that referenced this pull request Feb 28, 2019

msjenkins-r7 added a commit that referenced this pull request Feb 28, 2019

@busterb

This comment has been minimized.

Copy link
Contributor

busterb commented Feb 28, 2019

Release Notes

This updates the winrm_cmd aux module to always log the command output.

@busterb

This comment has been minimized.

Copy link
Contributor

busterb commented Feb 28, 2019

Added b22c496. Thanks @Yashvendra

@Yashvendra Yashvendra deleted the Yashvendra:winrm branch Mar 1, 2019

@mkienow-r7

This comment has been minimized.

Copy link
Contributor

mkienow-r7 commented Mar 8, 2019

I noticed the associated issue is still open, likely because one of the keywords wasn't used in front of the issue number. Would someone please confirm if this PR resolved #11440?

@busterb

This comment has been minimized.

Copy link
Contributor

busterb commented Mar 8, 2019

Thanks @mkienow-r7, I'd say it does the right thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.