Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SideEffects Stability Reliability check #11446

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
None yet
4 participants
@jrobles-r7
Copy link
Contributor

jrobles-r7 commented Feb 21, 2019

Add INFO warning to msftidy if SideEffects, Stability, or Reliability are provided without a Rank.

Verification

  • Test module w/ SideEffects/Stability/Reliability without rank
  • tools/dev/msftidy.rb path/to/module.rb
@@ -435,6 +435,8 @@ def check_ranking
if not available_ranks.include?($1)
error("Invalid ranking. You have '#{$1}'")
end
elsif @source =~ /['"](SideEffects|Stability|Reliability)['"]\s+=/

This comment has been minimized.

@bcoles

bcoles Feb 22, 2019

Contributor

Whitespace should be present, but doesn't have to be.

Suggested change
elsif @source =~ /['"](SideEffects|Stability|Reliability)['"]\s+=/
elsif @source =~ /['"](SideEffects|Stability|Reliability)['"]\s*=/

Other msftidy checks also use \s* match.

@bcoles bcoles added the msftidy label Feb 22, 2019

@busterb busterb self-assigned this Feb 22, 2019

@busterb busterb merged commit c09c156 into rapid7:master Feb 25, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

busterb added a commit that referenced this pull request Feb 25, 2019

@busterb

This comment has been minimized.

Copy link
Contributor

busterb commented Feb 25, 2019

Added 8cc3070 per the suggestion above. Thanks all!

msjenkins-r7 added a commit that referenced this pull request Feb 25, 2019

@busterb

This comment has been minimized.

Copy link
Contributor

busterb commented Feb 25, 2019

Release Notes

This adds support for msftidy to understand the new SideEffects, Stability, and Reliability attributes in modules, allowing these to supersede the single-dimensional 'rank' attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.