Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firmware version checking to Wemo exploit #11464

Merged
merged 2 commits into from Mar 5, 2019

Conversation

Projects
None yet
4 participants
@nstarke
Copy link
Contributor

nstarke commented Feb 22, 2019

Resolves #11452 by parsing out the version
information returned in /setup.xml. New code then performs
a version check, and then alerts the user to whether or not
it is likely the remote host is vulnerable given that version
check.

Tell us what this change does. If you're fixing a bug, please mention
the github issue number.

Please ensure you are submitting from a unique branch in your repository to master in Rapid7's.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use exploit/windows/smb/ms08_067_netapi
  • ...
  • Verify the thing does what it should
  • Verify the thing does not do what it should not
  • Document the thing and how it works (Example)

#11409

@wvu-r7 wvu-r7 self-assigned this Feb 23, 2019

@nstarke nstarke force-pushed the nstarke:branchces/issue-11452-adding-version-check-for-wemo branch from 57e198e to dacf588 Feb 23, 2019

@nstarke

This comment has been minimized.

Copy link
Contributor Author

nstarke commented Feb 23, 2019

and of course I messed things up trying to rebase. @wvu-r7 I will look to you for some guidance on whether or not I should create a new PR or somehow try to fix this one.

@nstarke

This comment has been minimized.

Copy link
Contributor Author

nstarke commented Feb 23, 2019

welp that looks better but still leaves an ugly commit log. If anyone wants to walk me thru how to rebase that to a single commit I'll be happy to update this PR.

@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Feb 23, 2019

git rebase -i upstream/master should do the trick.

Adding version checking to wemo module
Addresses Github Issue 11452 by parsing out the version
information returned in /setup.xml. New code then performs
a version check, and then alerts the user to whether or not
it is likely the remote host is vulnerable given that version
check.

@nstarke nstarke force-pushed the nstarke:branchces/issue-11452-adding-version-check-for-wemo branch from 67dca8e to d01bda0 Feb 23, 2019

@nstarke

This comment has been minimized.

Copy link
Contributor Author

nstarke commented Feb 23, 2019

I'm not sure what I'm doing wrong. I ran git rebase -i upstream/master. going to revert again

@nstarke nstarke force-pushed the nstarke:branchces/issue-11452-adding-version-check-for-wemo branch from 0952ac4 to 6bd1489 Feb 23, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Feb 23, 2019

Looks fine now!

@nstarke

This comment has been minimized.

Copy link
Contributor Author

nstarke commented Feb 23, 2019

isn't it missing the NOCVE changes?

@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Feb 23, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Feb 27, 2019

@nstarke: I'm going to address the rest of the review comments and get this landed. Thanks for the work!

@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Feb 27, 2019

setup.xml files for unpatched Crock-Pot and patched Switch: #11452 (comment).

@nstarke

This comment has been minimized.

Copy link
Contributor Author

nstarke commented Feb 27, 2019

I'm sorry I havent been able to update this in a few days

@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Feb 27, 2019

No worries. I'm sorry I'm so picky. :)

wvu-r7 added a commit to wvu-r7/metasploit-framework that referenced this pull request Mar 5, 2019

@wvu-r7 wvu-r7 merged commit 7c7a233 into rapid7:master Mar 5, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Mar 5, 2019

msjenkins-r7 added a commit that referenced this pull request Mar 5, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Mar 5, 2019

Release Notes

This adds firmware version checking to the check method in exploit/linux/upnp/belkin_wemo_upnp_exec.

@wvu-r7 wvu-r7 changed the title Adding version checking to wemo module Add firmware version checking to Wemo exploit Mar 5, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Mar 5, 2019

Sorry for the flurry of commits and PRs. It's done now. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.