Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup changes from DB Manager for Payloads #11532

Merged
merged 5 commits into from Mar 6, 2019

Conversation

Projects
None yet
4 participants
@mkienow-r7
Copy link
Contributor

mkienow-r7 commented Mar 6, 2019

  • Updates the PayloadDataProxy module to use the data_service_operation block. #10956 introduced changes to update all DataProxy modules to use the data_service_operation block, however, the changes from #10675 were made in advance of those and delayed, but not updated prior to being landed.
  • Adds a missing ActiveRecord connection block in Msf::DBManager::Payload.
  • Adds an entry to autoload RemotePayloadDataService in order to fix a NoMethodError exception when connected to a remote data service
  • Adds a check that the database is active in the Msf::Handler#create_session method before looking up a payload based on UUID to fix a ActiveRecord::ConnectionNotEstablished exception when working without a database.

Verification

Follow verification steps from #10675, except start the web service using msfdb rather than msfdb_ws.

@mkienow-r7 mkienow-r7 added the msf5 label Mar 6, 2019

@bwatters-r7

This comment has been minimized.

Copy link
Contributor

bwatters-r7 commented Mar 6, 2019

I get the following exceptions with windows/x64/meterpreter/reverse_https:
image

@mkienow-r7

This comment has been minimized.

Copy link
Contributor Author

mkienow-r7 commented Mar 6, 2019

@bwatters-r7 Were you getting that error before testing the PR? These changes were not necessarily going to resolve payload - data service related issues, rather, it was simply to implement a pattern that should have been implemented.

@bwatters-r7

This comment has been minimized.

Copy link
Contributor

bwatters-r7 commented Mar 6, 2019

That is the same error introduced yesterday. I was unclear about the goal, so I figured I'd chime in.

@mkienow-r7

This comment has been minimized.

Copy link
Contributor Author

mkienow-r7 commented Mar 6, 2019

@bwatters-r7 It is appreciated! This was something that caught my eye and I wanted to get a quick correction in while the issue is being investigated.

mkienow-r7 added some commits Mar 6, 2019

@mkienow-r7 mkienow-r7 changed the title Update PayloadDataProxy to use the data_service_operation block Cleanup changes from DB Manager for Payloads Mar 6, 2019

mkienow-r7 added some commits Mar 6, 2019

@asoto-r7 asoto-r7 merged commit f873d94 into rapid7:master Mar 6, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details

asoto-r7 added a commit that referenced this pull request Mar 6, 2019

@asoto-r7 asoto-r7 referenced this pull request Mar 6, 2019

Closed

Fix https payload db exception #11526

0 of 9 tasks complete

@mkienow-r7 mkienow-r7 added the bug label Mar 6, 2019

@mkienow-r7 mkienow-r7 deleted the mkienow-r7:add-payload-data-service-operation-block-pattern branch Mar 6, 2019

@busterb

This comment has been minimized.

Copy link
Contributor

busterb commented Mar 6, 2019

Release Notes

This updates the changes from PR #10675 to match the current structure of Metasploit data proxy code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.