Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jobify support with aux modules #11551

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@busterb
Copy link
Contributor

busterb commented Mar 11, 2019

Looks like we hit another bug involving variable scope in parameters passed down to run_simple via 'run_single'. Since 'run_single' doesn't actually even run a single invocation of a module, let's just unwind that function, and get the rest of the parameters passed down.

This also explicitly disables 'jobify' support for non-scanner aux modules with multiple targets, which I don't think we're ready for until we add the RHOSTS iteration to the module proper. Otherwise, we'll have an explosion of jobs in the current implementation.

Fixes #11550

Verification

  • Follow reproduction steps for #11550
  • Verify 'exploit -j' / 'run -j' work as expected
fix jobify support with aux modules
Looks like we hit another bug involving variable scope in parameters passed down to run_simple via 'run_single'. Since 'run_single' doesn't actually even run a single invocation of a module, let's just unwind that function, and get the rest of the parameters passed down.

This also explicitly disables 'jobify' support for non-scanner aux modules with multiple targets, which I don't think we're ready for until we add the RHOSTS iteration to the module proper. Otherwise, we'll have an explosion of jobs in the current implementation.

@wvu-r7 wvu-r7 merged commit d14ace4 into rapid7:master Mar 11, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

wvu-r7 added a commit that referenced this pull request Mar 11, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Mar 11, 2019

Release Notes

This fixes a regression in which auxiliary modules could no longer run as a background job.

@jmartin-r7 jmartin-r7 added the msf5 label Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.