Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
add no cleanup to jtr modules #11570
There are times when running the jtr aux modules you don't want to delete the temporary files. Cases like debugging, or exporting the DB in a friendly format to run john elsewhere.
bcoles left a comment
I joke about temp files, but if there's a reason for not deleting them, then perhaps there's a use case here suggesting temp files aren't appropriate? (Evidently, I haven't looked at the backstory to this PR closely).
Is there a use for storing any of these temp files as loot ?
Prior to the big jtr cleanup, the files were written to temp but never deleted. Seemed sloppy, as there isn't much use for them after the module runs other than when I was debugging my own modules.
Creds currently has an output function, but since we're doing some altering of the hash to make it in a JTR accepted format, this functionality isn't 1:1.
I don't think its worth putting them in loot since theyre already in creds, just in a different format, and running the module multiple times (maybe with a different wordlist file) may create multiple loots of the same file.