Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update CONTRIBUTING.md advice on topic branches #11720
This updates the verbiage in
We never verified why GitHub diffs can get messed up over time. I'm partly to blame for perpetuating the line that it was a
FWIW, there was no technical reason a
We wanted contributors to learn the best practice, so closing their PR was the approach we took. The only drawback we've noted is that review history should be cross-referenced between PRs. This can be as simple as tagging the old PR's number in the new PR's description.
Words from @jmartin-r7.