Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display NOCVE reason cleanly in info command output #11820

Merged
merged 4 commits into from May 14, 2019

Conversation

Projects
None yet
2 participants
@wvu-r7
Copy link
Contributor

commented May 7, 2019

Separated from #11785 for landability. For repro, run the info command on a module with NOCVE set. See the linked PR for context.

The key takeaway here is that references should be links, not free-form text. That's for notes.

@jmartin-r7

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

@msjenkins-r7 test this please.

@wvu-r7 wvu-r7 changed the title Display NOCVE reason in missing CVE reference Display NOCVE reason cleanly in info command output May 13, 2019

@jmartin-r7 jmartin-r7 self-assigned this May 13, 2019

@jmartin-r7 jmartin-r7 merged commit ca13769 into rapid7:master May 14, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jmartin-r7 added a commit that referenced this pull request May 14, 2019

msjenkins-r7 added a commit that referenced this pull request May 14, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

Thank you, @jmartin-r7!

@wvu-r7 wvu-r7 deleted the wvu-r7:feature/nocve branch May 14, 2019

@jmartin-r7

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Release Notes

Console references pertaining to modules with no CVE documented are now more concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.