Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSB references to use docs.microsoft.com #11843

Merged
merged 4 commits into from May 23, 2019

Conversation

Projects
None yet
4 participants
@PierrickV
Copy link
Contributor

commented May 16, 2019

new pull request for : fix broken links #11836

This commit fix broken links mostly to Microsoft website.
I also used Internet Archive for some disappeared website.

Tell us what this change does. If you're fixing a bug, please mention
the github issue number.

Please ensure you are submitting from a unique branch in your repository to master in Rapid7's.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use exploit/windows/smb/ms08_067_netapi
  • ...
  • Verify the thing does what it should
  • Verify the thing does not do what it should not
  • Document the thing and how it works (Example)

@h00die h00die self-assigned this May 16, 2019

@jrobles-r7
Copy link
Contributor

left a comment

The URLs that are generated from the MSB references create links that redirect to the https://docs.microsoft.com.
Maybe the https://docs.microsoft.com URLs can be removed from the modules.

@@ -37,9 +37,9 @@ def initialize(info = {})
[ 'CVE', '2010-0483' ],
[ 'OSVDB', '62632' ],
[ 'MSB', 'MS10-023' ],

This comment has been minimized.

Copy link
@jrobles-r7

jrobles-r7 May 21, 2019

Contributor
Suggested change
[ 'MSB', 'MS10-023' ],
[ 'MSB', 'MS10-022' ],
[ 'URL', 'http://www.microsoft.com/technet/security/advisory/981169.mspx' ],
[ 'URL', 'http://blogs.technet.com/msrc/archive/2010/02/28/investigating-a-new-win32hlp-and-internet-explorer-issue.aspx' ],
[ 'URL', 'http://isec.pl/vulnerabilities/isec-0027-msgbox-helpfile-ie.txt' ]
[ 'URL', 'https://docs.microsoft.com/en-us/security-updates/securitybulletins/2010/ms10-023' ],

This comment has been minimized.

Copy link
@jrobles-r7

jrobles-r7 May 21, 2019

Contributor
Suggested change
[ 'URL', 'https://docs.microsoft.com/en-us/security-updates/securitybulletins/2010/ms10-023' ],
[ 'URL', 'https://docs.microsoft.com/en-us/security-updates/securitybulletins/2010/ms10-022' ],
@h00die

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

@PierrickV i just finished double checking all the links. @jrobles-r7 caught everything, and all the new links are valid. Once you implement those changes, this will be good to land!

@jrobles-r7

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

@h00die I talked with @acammack-r7 about this and we're going to update the MSB references to point to docs.microsoft.com instead of technet. That will allow us to remove the docs references from the modules and just use the MSB instead.

@h00die

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

10-4, do you want to take this over then? i dont mind

@jrobles-r7

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Yes I'll take this one

jrobles-r7 added some commits May 23, 2019

Update MSB reference
Previous MSB references were redirecting to docs.microsoft.com
Remove references to doc.microsoft.com bulletin
MSB references point to this location

@jrobles-r7 jrobles-r7 self-assigned this May 23, 2019

@jrobles-r7 jrobles-r7 changed the title Fix broken links mostly to Microsoft website Update MSB references to use docs.microsoft.com May 23, 2019

@jrobles-r7 jrobles-r7 merged commit db353a7 into rapid7:master May 23, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jrobles-r7 added a commit that referenced this pull request May 23, 2019

@jrobles-r7

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

Release Notes

This updates the links generated from MSB references to security bulletins on docs.microsoft.com.

jmartin-r7 added a commit that referenced this pull request May 23, 2019

@PierrickV PierrickV deleted the PierrickV:fix-broken-links-to-ms branch May 23, 2019

@gdavidson-r7 gdavidson-r7 added the rn-fix label May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.