Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for post/multi/gather/jenkins_gather #11847

Merged
merged 1 commit into from May 22, 2019

Conversation

Projects
None yet
3 participants
@thesubtlety
Copy link
Contributor

commented May 17, 2019

I think this module has a user base of one:) Ran this the other day and ran into an issue with parsing key material for later Jenkins versions and a nil error. Also noticed that API keys were blank since later Jenkins versions are hashing the API key rather than encrypting it as in previous versions.

This PR

  • removes the strip call while parsing key files
  • changes empty to blank to gracefully recover from nil user object
  • no longer reports on blank/unrecoverable API tokens

Verification

  • Start msfconsole and obtain a session to a server running Jenkins
  • use post/multi/gather/jenkins_gather, set session 1, run
  • Output should return expected saved secrets and not display blank API tokens

@wvu-r7 wvu-r7 added bug module labels May 21, 2019

@wvu-r7 wvu-r7 self-assigned this May 21, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

Happy to grab this, since I'm currently working on Jenkins.

@wvu-r7 wvu-r7 merged commit 4f679fa into rapid7:master May 22, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wvu-r7

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Release Notes

This fixes a few bugs in post/multi/gather/jenkins_gather.

wvu-r7 added a commit that referenced this pull request May 22, 2019

msjenkins-r7 added a commit that referenced this pull request May 22, 2019

@gdavidson-r7 gdavidson-r7 added the rn-fix label May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.