Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smb client pipe_auditor module now preprends missing backslash to pip… #11856

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@NoodleOfDeath
Copy link
Contributor

commented May 19, 2019

The named_pipes.txt wordlist provided by the metasploit framework contains pipe names that are not prefixed with a backslash. The 'auxiliary/scanner/smb/pipe_auditor' module does not work properly unless each pipe name is prefixed with a backslash. I updated 'lib/exploit/smb/client/pipe_auditor.rb' to check for the missing backslash and to prepend it if missing.

Tell us what this change does. If you're fixing a bug, please mention
the github issue number.

Please ensure you are submitting from a unique branch in your repository to master in Rapid7's.

Verifications

List the steps needed to make sure this thing works

  • Start msfconsole
  • use auxiliary/scanner/smb/pipe_auditor
  • Verify the thing does what it should
    Running with default named_pipes.txt does not work without fix and does with fix
  • Document (nothing to document or no existing documents to add to)

Fixes #9618.

@wvu-r7 wvu-r7 self-assigned this May 19, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

How the heck did it work without \ when we tested it in #9618? Is this a regression? What you've done should be correct, though. Thanks!

@wvu-r7

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

If you're willing, please resubmit this PR from a topic branch as per https://github.com/rapid7/metasploit-framework/blob/master/CONTRIBUTING.md#code-contributions. Thank you.

@NoodleOfDeath

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

Resubmitted on a unique branch

@bcoles

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.