Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the meterpreter > screenshot command to only upload the dll on Windows #11904

Merged
merged 1 commit into from Jun 18, 2019

Conversation

Projects
None yet
4 participants
@timwr
Copy link
Contributor

commented May 30, 2019

Currently we upload the screenshot dll on all platforms whenever we take a screenshot. This PR updates it so we only do this on Windows.

@ccondon-r7 ccondon-r7 added the a2k19 label May 31, 2019

@Chiggins Chiggins self-assigned this May 31, 2019

@Chiggins Chiggins merged commit 17ffd83 into rapid7:master Jun 18, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Chiggins added a commit that referenced this pull request Jun 18, 2019

msjenkins-r7 added a commit that referenced this pull request Jun 18, 2019

@timwr

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

Thanks! I wonder if we can improve it so it only sends the screenshot DLL once. It seems kill the performance of the screenshare module currently and the session freezes sometimes.

@tdoan-r7 tdoan-r7 added the rn-fix label Jun 25, 2019

@tdoan-r7

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2019

Release Notes

Screenshot DLL will now only get uploaded on Windows instead of all platforms when a screenshot is taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.