Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix osx 10.7 hash IDing, and JTR ids #11906

Merged
merged 1 commit into from Jun 1, 2019

Conversation

Projects
None yet
3 participants
@h00die
Copy link
Contributor

commented May 30, 2019

This PR fixes the JTR tags on OSX hashes (since they are standard sha1 and sha512). Next, @jmartin-r7 and I discovered that on 10.7 the ending capture wasn't hitting on his test box. Since it's a hash, with a set length, we change the regex to just match on length instead.

Verification

List the steps needed to make sure this thing works

  • find a 10.7 box and make sure it captures the hash correctly

@h00die h00die added osx a2k19 labels May 30, 2019

@busterb busterb self-assigned this Jun 1, 2019

@busterb busterb merged commit 06256cc into rapid7:master Jun 1, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

busterb added a commit that referenced this pull request Jun 1, 2019

@busterb

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

Release Notes

This fix addresses the JTR tags on OSX hashes, since they are standard SHA1 and SHA512, and adjusts the regex for macOS 10.7 hashes to match properly.

msjenkins-r7 added a commit that referenced this pull request Jun 1, 2019

@h00die h00die deleted the h00die:osx_hash_fixes branch Jun 2, 2019

@tdoan-r7 tdoan-r7 added the rn-fix label Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.