Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix java/android cmd_exec and shell_command_token #11911

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
4 participants
@busterb
Copy link
Member

commented May 31, 2019

This change fixes a race condition in the cmd_exec tests and #11530

From rapid7/metasploit-payloads#334

Verification

  • Using any Java/android meterpreter payload, run the cmd_exec tests:
loadpath test/modules/
use post/test/cmd_exec 
set SESSION -1
run
  • Verify that the tests pass.
fix java/android cmd_exec and shell_command_token
This change fixes a race condition in the cmd_exec tests and #11530

From rapid7/metasploit-payloads#334

@wvu-r7 wvu-r7 self-assigned this May 31, 2019

@bwatters-r7

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

cmd_exec tests added to java payload tests

@wvu-r7

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

msf5 post(test/cmd_exec) > run

[!] SESSION may not be compatible with this module.
[*] Running against session -1
[*] Session type is meterpreter and platform is osx
[*] Starting cmd_exec quote tests
[+] should return the result of echo with single quotes
[+] should return the result of echo with double quotes
[*] Starting cmd_exec tests
[+] should return the result of echo
[+] should return the result after sleeping
[+] should return the full response after sleeping
[+] should return the result of echo 10 times
[*] Finished cmd_exec tests
[*] Testing complete in 2.933318
[*] Passed: 6; Failed: 0
[*] Post module execution completed
msf5 post(test/cmd_exec) >

@wvu-r7 wvu-r7 merged commit 526df18 into rapid7:master May 31, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

wvu-r7 added a commit that referenced this pull request May 31, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Release Notes

This fix resolves an issue in cmd_exec and shell_command_token in the Java and Android payloads.

jmartin-r7 added a commit that referenced this pull request Jun 1, 2019

@tdoan-r7 tdoan-r7 added the rn-fix label Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.