Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix cmd_exec tests on python/windows #11938
This change works around #11935
List the steps needed to make sure this thing works
I'm waffling on this. On one hand, this means we deal with arg strings on exe and java meterpreters differently than python. That feels wrong, but it is reality. We use CreateProcess and pass the args through on exe windows meterpreter and subprocess.Popen to do it on python.
I'm thinking what you did here is the best option, as trying to fix it might not be a great idea.
Jun 4, 2019
This is a temporary bug fix for how we interpret quotes in Meterpreter commands. Currently, Python on Windows handles quotation marks differently than exe or Java Meterpreter handles them. This fix adapts the test to verify that they work, but not that they are treated equally.