Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abrt_raceabrt_priv_esc: Fix abrt package version check #11958

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
3 participants
@bcoles
Copy link
Contributor

commented Jun 10, 2019

Fix abrt package version check.

Retrieving package details with yum list installed <pkg>, on old OS with outdated pacakges, may print a warning to stderr indicating that the package cache is old. This caused the package version check to fail, as the following grep call (intended to extract details for the specified package) operated only on stdout, allowing both the warning from stderr and the package details to be returned to Metasploit causing subsequent regex matching to fail

See: #11762 (comment)

@bwatters-r7

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

New check works on the stale yum for centOS
image

[*] System is using ABRT package version 2.1.11-52.el7.centos
[+] System is configured to use ABRT for crash reporting

@bwatters-r7 bwatters-r7 merged commit 8cac968 into rapid7:master Jun 13, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

bwatters-r7 added a commit that referenced this pull request Jun 13, 2019

Land #11958, abrt_raceabrt_priv_esc: Fix abrt package version check
Merge branch 'land-11958' into upstream-master
@bwatters-r7

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Release Notes

This fix resolves an issue in the code that determines the version via yum command. It now adequately filters out error messages that yum prints in an effort to be helpful.

msjenkins-r7 added a commit that referenced this pull request Jun 13, 2019

Land #11958, abrt_raceabrt_priv_esc: Fix abrt package version check
Merge branch 'land-11958' into upstream-master

@bcoles bcoles deleted the bcoles:abrt_raceabrt_priv_esc branch Jun 14, 2019

@tdoan-r7 tdoan-r7 added the rn-fix label Jun 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.