Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert rex-socket back to 0.1.17 for now #12045

Merged
merged 1 commit into from Jul 2, 2019

Conversation

Projects
None yet
3 participants
@busterb
Copy link
Member

commented Jul 2, 2019

This reverts a change that causes SSL certificate generation to not working properly through all of the various shim functions in rex-socket. This is the quickest fix which grants some time to ponder if the interface could be a little more robust in rex-socket in the first place.

Fixes #12037 and #12038

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use multi/handler
  • set payload windows/meterpreter/reverse_https
  • run
  • Verify the listener listens with no errors
revert rex-socket back to 0.1.17 for now
This reverts a change that causes SSL certificate generation to not working properly through all of the various shim functions in rex-socket. This is the quickest fix which grants some time to ponder if the interface could be a little more robust in rex-socket in the first place.

@busterb busterb added the bug label Jul 2, 2019

@busterb busterb requested review from wvu-r7 and mkienow-r7 Jul 2, 2019

@busterb busterb added the payload label Jul 2, 2019

@wvu-r7

wvu-r7 approved these changes Jul 2, 2019

Copy link
Contributor

left a comment

Looks like a good lock to me.

@busterb

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

Cool, I'll wait for jenkins and land it if it's cool. Thanks!

@mkienow-r7
Copy link
Contributor

left a comment

LGTM

@busterb

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

Travis CI is currently over 1450 jobs behind in its backlog, so nothing has moved in the last 12 minutes. Tested locally and ran rspec, landing.

@busterb busterb merged commit 6ab02ba into rapid7:master Jul 2, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details

busterb added a commit that referenced this pull request Jul 2, 2019

@busterb

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

Release Notes

This fixes an issue where reverse_https handlers would report that they did not properly bind to a free port.

@busterb busterb self-assigned this Jul 2, 2019

msjenkins-r7 added a commit that referenced this pull request Jul 8, 2019

@bwatters-r7 bwatters-r7 referenced this pull request Jul 8, 2019

Closed

reverse_https not binding #12046

0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.