Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle passthrough commands #12080

Merged
merged 1 commit into from Jul 11, 2019

Conversation

Projects
None yet
2 participants
@acammack-r7
Copy link
Contributor

commented Jul 10, 2019

The system method handles input and output as appropriate, allowing
programs that need user input to execute properly without racing
msfconsole over STDIN

Verification

  • ./msfconsole
  • man git-push
  • Verify that the you can navigate the man page and none of the input gets unexpectedly eaten, and none of the output clobbered
  • python
  • Verify that you can interact normally with the Python shell
Gracefully handle passthrough commands
The `system` method handles input and output as appropriate, allowing
programs that need user input to execute properly without racing
msfconsole over STDIN

@wvu-r7 wvu-r7 self-assigned this Jul 11, 2019

@wvu-r7

wvu-r7 approved these changes Jul 11, 2019

Copy link
Contributor

left a comment

Good enhancement/fix.

I like the pattern. Used it in #9303.

@wvu-r7 wvu-r7 merged commit b419ab0 into rapid7:master Jul 11, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

wvu-r7 added a commit that referenced this pull request Jul 11, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Release Notes

When an unknown command is executed in msfconsole, it is passed through to the shell. This changes that functionality to use the system method instead of popen, allowing for correct handling of input and output.

msjenkins-r7 added a commit that referenced this pull request Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.