Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing path or module's documentation (issue #8296) #12135

Merged
merged 3 commits into from Jul 29, 2019

Conversation

@hkerma
Copy link
Contributor

commented Jul 27, 2019

Hi, I was following issue #8296. We will soon update the the list of undocumented modules, but for now, we found 3 issues with existing documentation :

  • java_jmx_scanner module is named java_jmx_server (pull request #10401), but the documentation was still java_jmx_scanner.md. Fixed in this PR.
  • Both mssql_idf and mssql_sql modules are now in /auxiliary/admin/mssql but the documentations are in /auxiliary/scanner/mssql. It's been fixed by creating a new directory mssql in documentation/modules/auxiliary/admin/ and moving both documentation files in it.

This is my first PR ever, I hope I did well : please tell me if there's anything wrong !!

hkerma added some commits Jul 25, 2019

Merge pull request #1 from rapid7/master
Updating from upstream
Moved documentation files mssql_sql.md and mssql_idf.md from document…
…ation/modules/auxiliary/scanner/mssql/ to /documentation/modules/auxiliary/admin/mssql/ to match which the module's directory

@h00die h00die self-assigned this Jul 29, 2019

@h00die h00die merged commit 5b78788 into rapid7:master Jul 29, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

h00die added a commit that referenced this pull request Jul 29, 2019

@h00die

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Release Notes

This PR adjust the locations of 3 docs to their module locations so they can be properly referenced.

msjenkins-r7 added a commit that referenced this pull request Jul 29, 2019

@h00die

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

@hkerma Thanks for the first time contrib! I did add a few super minor things 8f95ccc so that everything lined up correctly. Thanks for the help on keeping all the docs in line, its a daunting task!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.