Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescue EOFError in cve_2019_0708_bluekeep get_once #12152

Merged
merged 3 commits into from Aug 2, 2019

Conversation

@wvu-r7
Copy link
Contributor

commented Jul 31, 2019

Fixes #12149, potentially.

@cnotin

@cnotin

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

Thanks! I'll test it tomorrow and tell you!

@cnotin

This comment has been minimized.

Copy link
Contributor

commented on modules/auxiliary/scanner/rdp/cve_2019_0708_bluekeep.rb in ae13736 Jul 31, 2019

Double "raise"? (maybe a ruby thing that I don't know)

This comment has been minimized.

Copy link
Contributor Author

replied Jul 31, 2019

Technically, EOFError would be raised by get_once before it returns nil, so this would hit first.

This comment has been minimized.

Copy link
Contributor Author

replied Jul 31, 2019

It's perhaps more defensive to leave the check for nil and handle EOFError at the same time.

This comment has been minimized.

Copy link
Contributor Author

replied Jul 31, 2019

OH, CRAP. That's a typo. Literal double raise.

@cnotin

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

I've tested and the output is better now!

[*] a.b.c.d:3389    - Verifying RDP protocol...
[*] a.b.c.d:3389    - Attempting to connect using TLS security
[*] a.b.c.d:3389    - Server requests TLS
[*] a.b.c.d:3389    - Sending erect domain request
[*] a.b.c.d:3389    - Sending client info PDU
[*] a.b.c.d:3389    - Received License packet
[*] a.b.c.d:3389    - Sending client confirm active PDU
[*] a.b.c.d:3389    - Sending client synchronize PDU
[*] a.b.c.d:3389    - Sending client control cooperate PDU
[*] a.b.c.d:3389    - Sending client control request control PDU
[*] a.b.c.d:3389    - Sending client input sychronize PDU
[*] a.b.c.d:3389    - Sending client font list PDU
[-] a.b.c.d:3389    - Connection reset
[*] a.b.c.d:3389    - The target service is running, but could not be validated.
Rescue EOFError in quick check for patch
Thank you to @cnotin for noticing this case.
@wvu-r7

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

@cnotin: Please see if #12149 (comment) is addressed. Thank you. :)

@cnotin

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

@wvu-r7 all good for me! Thanks :)

@wvu-r7 wvu-r7 self-assigned this Aug 2, 2019

@wvu-r7 wvu-r7 merged commit 178339d into rapid7:master Aug 2, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

wvu-r7 added a commit that referenced this pull request Aug 2, 2019

@wvu-r7 wvu-r7 deleted the wvu-r7:bug/bluekeep branch Aug 2, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

Release Notes

The EOFError error no longer occurs while scanning for the BlueKeep vulnerability.

msjenkins-r7 added a commit that referenced this pull request Aug 2, 2019

@tdoan-r7 tdoan-r7 added the rn-fix label Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.