Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ruby version for latest goodies #12387

Merged
merged 3 commits into from Oct 3, 2019

Conversation

@jmartin-r7
Copy link
Contributor

commented Oct 3, 2019

Just bumps rvm to use the latest released ruby 2.6 version.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • Verify some random things
  • Verify all Travis automated testing passes
@jmartin-r7

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

@msjenkins-r7 test this please.

@bwatters-r7

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

Looks like the session for one of the linux targets died in the middle of the test:
image

[*] Setup: changing working directory to /tmp
[*] Running against session 1
[*] Session type is meterpreter and platform is linux
[*] Starting process tests
[*] Pid: 845
[+] should return its own process id
[-] FAILED: should return a list of processes
@jmartin-r7

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

New test run succeed, error seem to be intermittent issue on the payload test.

@busterb busterb added the ruby-compat label Oct 3, 2019
@busterb busterb self-assigned this Oct 3, 2019
bcook-r7 pushed a commit that referenced this pull request Oct 3, 2019
@bcook-r7 bcook-r7 merged commit c2fe096 into rapid7:master Oct 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
msjenkins-r7 added a commit that referenced this pull request Oct 3, 2019
@busterb

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

I bumped Ruby 2.5 in Travis and docker as well.

@jmartin-r7 jmartin-r7 deleted the jmartin-r7:bump-ruby-2.6.5 branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.