Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the link for 'COPYING' file #12417

Closed
wants to merge 1 commit into from

Conversation

@Seniru
Copy link
Contributor

Seniru commented Oct 7, 2019

This PR will link the word 'COPYING' in the README to 'COPYING' file.

@dwelch-r7

This comment has been minimized.

Copy link
Contributor

dwelch-r7 commented Oct 8, 2019

Do create a topic branch to work on instead of working directly on master. This helps protect the process, ensures users are aware of commits on the branch being considered for merge, allows for a location for more commits to be offered without mingling with other contributor changes, and allows contributors to make progress while a PR is still being reviewed.

https://github.com/rapid7/metasploit-framework/blob/master/CONTRIBUTING.md

Please feel free to re-open this PR from a topic branch rather than master

@dwelch-r7 dwelch-r7 closed this Oct 8, 2019
@Seniru

This comment has been minimized.

Copy link
Contributor Author

Seniru commented Oct 8, 2019

Sorry for that. I didn't understand what was it saying.
Can you tell me what branch should I choose to resend the PR, if possible?

@dwelch-r7

This comment has been minimized.

Copy link
Contributor

dwelch-r7 commented Oct 8, 2019

No problem, it's a lot to take in

you need to make a new branch on your fork of the repo, then make a PR from your new branch to rapid7:master

@Seniru

This comment has been minimized.

Copy link
Contributor Author

Seniru commented Oct 8, 2019

You mean like Seniru:patch?

@dwelch-r7

This comment has been minimized.

Copy link
Contributor

dwelch-r7 commented Oct 8, 2019

yup that'd be just fine

@Seniru Seniru referenced this pull request Oct 9, 2019
0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.