Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust for more limited require #12421

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@jmartin-r7
Copy link
Contributor

jmartin-r7 commented Oct 7, 2019

Reduce the scope of the require used in creds command output formatting to just the actual formatter.

In the future and likely related to getting #11695 landed the output formatting process may be better served to use consistent method names base on an interface.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • see output format test in #11575
  • Verify csv and jtr format output are still consistent
@jmartin-r7 jmartin-r7 requested review from h00die and acammack-r7 Oct 7, 2019
@fishsticksflafor

This comment was marked as off-topic.

Copy link

fishsticksflafor commented Oct 7, 2019

@jmartin-r7

This comment has been minimized.

Copy link
Contributor Author

jmartin-r7 commented Oct 7, 2019

@fishsticksflafor please keep comments in PRs on topic.

For quick questions please join the #slack team or IRC found on metasploit.com. If you have a new issue please open an issue and fill in the details that provide context to explain your problem. The message you are reporting is normal for startup when no database services are configured.

@jmartin-r7 jmartin-r7 added the msf5 label Oct 7, 2019
@busterb busterb self-assigned this Oct 8, 2019
busterb added a commit that referenced this pull request Oct 8, 2019
@busterb busterb merged commit 7389417 into rapid7:master Oct 8, 2019
3 checks passed
3 checks passed
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmartin-r7 jmartin-r7 deleted the jmartin-r7:reduce-require branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.