Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate module in the wrong place #12426

Merged
merged 1 commit into from Oct 8, 2019

Conversation

bwatters-r7
Copy link
Contributor

While checking out #12391, I discovered we have both a modules/post/windows/manage/payload_inject and a modules/exploit/windows/local/payload_inject. Both appear to perform the same function with the same underlying calls to allocate memory to the remote process, write to it, then launch a thread. In the case of the post version, there's a lot more overhead associated with the payload listener, as it is not directly supported.
If there's something in the metasploit mythology that explains this, we can close this, but otherwise, let's delete the post module?

@bwatters-r7 bwatters-r7 added the potato The issue submitter failed to update the default issue template or the issue is a literal potato label Oct 8, 2019
@busterb busterb self-assigned this Oct 8, 2019
@busterb busterb added the module label Oct 8, 2019
busterb added a commit that referenced this pull request Oct 8, 2019
@busterb busterb merged commit 47dd96d into rapid7:master Oct 8, 2019
@busterb
Copy link
Member

busterb commented Oct 8, 2019

Added aadfb84

msf5 auxiliary(admin/juniper/juniper_config) > use post/windows/manage/payload_inject

[!] *             The module post/windows/manage/payload_inject has been moved!              *
[!] *                 You are now using exploit/windows/local/payload_inject                 *
msf5 exploit(post/windows/manage/payload_inject) >

@tperry-r7 tperry-r7 added the rn-no-release-notes no release notes label Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module potato The issue submitter failed to update the default issue template or the issue is a literal potato rn-no-release-notes no release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants