Remove duplicate module in the wrong place #12426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While checking out #12391, I discovered we have both a
modules/post/windows/manage/payload_inject
and amodules/exploit/windows/local/payload_inject
. Both appear to perform the same function with the same underlying calls to allocate memory to the remote process, write to it, then launch a thread. In the case of the post version, there's a lot more overhead associated with the payload listener, as it is not directly supported.If there's something in the metasploit mythology that explains this, we can close this, but otherwise, let's delete the post module?