Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanner modules: explain limitation of THREADS option #12522

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@cnotin
Copy link
Contributor

cnotin commented Oct 31, 2019

Closes #12521

I hope the suggested string is good and clearer :)

Closes #12521
@wvu-r7
wvu-r7 approved these changes Nov 1, 2019
Copy link
Contributor

wvu-r7 left a comment

Looks good, though there are other THREADS options we may or may not want to change. I think this one should cover most bases.

@wvu-r7 wvu-r7 self-assigned this Nov 1, 2019
wvu-r7 added a commit that referenced this pull request Nov 7, 2019
@wvu-r7 wvu-r7 merged commit 38c09b8 into rapid7:master Nov 7, 2019
3 checks passed
3 checks passed
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Nov 7, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Nov 7, 2019

Release Notes

This updates the description for the THREADS option in scanner modules to clarify that only one thread is created per target host.

@cnotin cnotin deleted the cnotin:patch-1 branch Nov 7, 2019
jmartin-r7 added a commit that referenced this pull request Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.