Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64K ought to be enough for anyone #12556

Merged
merged 1 commit into from Nov 11, 2019
Merged

Conversation

bcoles
Copy link
Contributor

@bcoles bcoles commented Nov 10, 2019

This PR increases the maximum size for ASCII art banners to a much more reasonable 65_535 bytes.

The maximum size was last bumped from 4096 to 16384 in 34d637c in 2015 to make room for ponies.

Abusing the bug label because my unofficial ASCII art won't fit in less than 40K and there's no label for critical priority.

@bcoles bcoles added the bug label Nov 10, 2019
@ccondon-r7
Copy link
Contributor

You're a committer, @bcoles, you could always add a label for critical priority, as this very obviously is :)

@wvu wvu added the hotness Something we're really excited about label Nov 11, 2019
@wvu wvu self-assigned this Nov 11, 2019
Copy link
Contributor

@wvu wvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it can run on my VAX, I'm all for it.

wvu added a commit that referenced this pull request Nov 11, 2019
@wvu wvu merged commit d172534 into rapid7:master Nov 11, 2019
@wvu
Copy link
Contributor

wvu commented Nov 11, 2019

Release Notes

The maximum size for ASCII art banners has been increased to 65,535 bytes.

@bcoles bcoles deleted the lib-msf-ui-banner-size branch November 11, 2019 06:02
@23081998
Copy link

Maaf senior ku semua nya saya mau tanya gmana cara me non aktifkan sadap di hp androit saya mohon batuan nya senior gogel di hp saya berisi berita palsu
Atas bantuan nya saya ucapkan trimakasi.
Maaf jika kata kata saya kurang sopan.
Mohon bantuan nya trimakasi

@tdoan-r7 tdoan-r7 added the rn-fix release notes fix label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug hotness Something we're really excited about rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants