Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64K ought to be enough for anyone #12556

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@bcoles
Copy link
Contributor

bcoles commented Nov 10, 2019

This PR increases the maximum size for ASCII art banners to a much more reasonable 65_535 bytes.

The maximum size was last bumped from 4096 to 16384 in 34d637c in 2015 to make room for ponies.

Abusing the bug label because my unofficial ASCII art won't fit in less than 40K and there's no label for critical priority.

@bcoles bcoles added the bug label Nov 10, 2019
@ccondon-r7

This comment has been minimized.

Copy link
Contributor

ccondon-r7 commented Nov 10, 2019

You're a committer, @bcoles, you could always add a label for critical priority, as this very obviously is :)

@wvu-r7 wvu-r7 added the hotness label Nov 11, 2019
@wvu-r7 wvu-r7 self-assigned this Nov 11, 2019
@wvu-r7
wvu-r7 approved these changes Nov 11, 2019
Copy link
Contributor

wvu-r7 left a comment

If it can run on my VAX, I'm all for it.

wvu-r7 added a commit that referenced this pull request Nov 11, 2019
@wvu-r7 wvu-r7 merged commit d172534 into rapid7:master Nov 11, 2019
3 checks passed
3 checks passed
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wvu-r7

This comment has been minimized.

Copy link
Contributor

wvu-r7 commented Nov 11, 2019

Release Notes

This bumps the maximum size for ASCII art banners to 65,535 bytes.

msjenkins-r7 added a commit that referenced this pull request Nov 11, 2019
fengjixuchui added a commit to fengjixuchui/metasploit-framework that referenced this pull request Nov 11, 2019
Land rapid7#12556, 64K ought to be enough for anyone
@bcoles bcoles deleted the bcoles:lib-msf-ui-banner-size branch Nov 11, 2019
@23081998

This comment has been minimized.

Copy link

23081998 commented Nov 11, 2019

Maaf senior ku semua nya saya mau tanya gmana cara me non aktifkan sadap di hp androit saya mohon batuan nya senior gogel di hp saya berisi berita palsu
Atas bantuan nya saya ucapkan trimakasi.
Maaf jika kata kata saya kurang sopan.
Mohon bantuan nya trimakasi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.