Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for android hashdump #12593

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@h00die
Copy link
Contributor

h00die commented Nov 17, 2019

@timwr identified a switched case, which was happening on a double negative during my testing of #12497 .
This should fix non-samsung devices to correctly label the JTR for their hashes.

@h00die h00die requested a review from timwr Nov 17, 2019
@busterb busterb self-assigned this Nov 18, 2019
Copy link
Member

busterb left a comment

Looks reasonable to me.

timwr added a commit that referenced this pull request Nov 19, 2019
@timwr timwr merged commit a0e45f4 into rapid7:master Nov 19, 2019
3 checks passed
3 checks passed
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@timwr

This comment has been minimized.

Copy link
Contributor

timwr commented Nov 19, 2019

Release notes

Fixes the hash format in the credentials database for Samsung and non-Samsung Android hashes.

@jmartin-r7 jmartin-r7 added the msf5 label Nov 19, 2019
@jmartin-r7

This comment has been minimized.

Copy link
Contributor

jmartin-r7 commented Nov 19, 2019

Marked msf5 as this interacts with changes to password cracker module names. I will see about backporting to 4.x today. No backport expected.

@h00die h00die deleted the h00die:12497_fixes branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.