Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh_creds module tries to store ssh public keys (#1) #12601

Merged
merged 1 commit into from Nov 18, 2019

Conversation

@MangyCoyote
Copy link
Contributor

MangyCoyote commented Nov 18, 2019

Resolves #12599

Resolves #12599
@busterb busterb self-assigned this Nov 18, 2019
bcook-r7 pushed a commit that referenced this pull request Nov 18, 2019
@bcook-r7 bcook-r7 merged commit cfd86f6 into rapid7:master Nov 18, 2019
3 checks passed
3 checks passed
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@busterb

This comment has been minimized.

Copy link
Member

busterb commented Nov 18, 2019

Thanks @MangyCoyote

@busterb

This comment has been minimized.

Copy link
Member

busterb commented Nov 18, 2019

Release Notes

This updates the ssh_creds module to avoid storing public-only SSH keys, since they cannot be used later.

msjenkins-r7 added a commit that referenced this pull request Nov 18, 2019
@MangyCoyote

This comment has been minimized.

Copy link
Contributor Author

MangyCoyote commented Nov 19, 2019

You are welcome.
Method SSHKey.valid_ssh_public_key? does not recognize public ssh key correctly if key contains optional commentaries.
Did a PR to sshkey library too. Hoping it will reach metasploit sooner or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.