Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove jtr specific modules that are refactored #12912

Merged
merged 4 commits into from Feb 7, 2020

Conversation

@jmartin-r7
Copy link
Member

jmartin-r7 commented Feb 5, 2020

Closes the cycle on #11695 as Aliases now linked in by moved_from will load the appropriate new module.

msf5 > use auxiliary/analyze/jtr_aix

[!] *                  The module auxiliary/analyze/jtr_aix has been moved!                  *
[!] *                       You are using auxiliary/analyze/crack_aix                        *
msf5 auxiliary(analyze/jtr_aix) > options

Module options (auxiliary/analyze/jtr_aix):

   Name                  Current Setting  Required  Description
   ----                  ---------------  --------  -----------
   CONFIG                                 no        The path to a John config file to use instead of the default
   CRACKER_PATH                           no        The absolute path to the cracker executable
   CUSTOM_WORDLIST                        no        The path to an optional custom wordlist
   FORK                  1                no        Forks for John the Ripper to use
   INCREMENTAL           true             no        Run in incremental mode
   ITERATION_TIMEOUT                      no        The max-run-time for each iteration of cracking
   KORELOGIC             false            no        Apply the KoreLogic rules to John the Ripper Wordlist Mode(slower)
   MUTATE                false            no        Apply common mutations to the Wordlist (SLOW)
   POT                                    no        The path to a John POT file to use instead of the default
   USE_CREDS             true             no        Use existing credential data saved in the database
   USE_DB_INFO           true             no        Use looted database schema info to seed the wordlist
   USE_DEFAULT_WORDLIST  true             no        Use the default metasploit wordlist
   USE_HOSTNAMES         true             no        Seed the wordlist with hostnames from the workspace
   USE_ROOT_WORDS        true             no        Use the Common Root Words Wordlist
   WORDLIST              true             no        Run in wordlist mode


Auxiliary action:

   Name  Description
   ----  -----------
   john  Use John the Ripper

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use various modules removed here
  • Verify correct refactored module is loaded and functions as expected.
@jmartin-r7 jmartin-r7 requested review from h00die, wvu-r7 and acammack-r7 Feb 5, 2020
@jmartin-r7 jmartin-r7 added the easy label Feb 5, 2020
@wvu-r7
wvu-r7 approved these changes Feb 5, 2020
Copy link
Member

wvu-r7 left a comment

Seems legit!

Copy link
Contributor

acammack-r7 left a comment

Not all of these line up with the right aliases (like auxiliary/analyze/jtr_windows_fast) and I need to add support for multiple move warnings.

@jmartin-r7

This comment has been minimized.

Copy link
Member Author

jmartin-r7 commented Feb 6, 2020

@acammack-r7 thanks, I missed validating the multiple mappings. I can add the Aliases directly on reduce to a single moved_from for those.

acammack-r7 and others added 3 commits Feb 6, 2020
Each `moved_from` deprecation in a module with more that one will now
print their respective warnings.
@h00die

This comment has been minimized.

Copy link
Contributor

h00die commented Feb 7, 2020

untested looks fine to me

@h00die
h00die approved these changes Feb 7, 2020
@wvu-r7
wvu-r7 approved these changes Feb 7, 2020
Copy link
Member

wvu-r7 left a comment

Approving because everyone else is doing it.

@adamgalway-r7 adamgalway-r7 self-assigned this Feb 7, 2020
adamgalway-r7 added a commit that referenced this pull request Feb 7, 2020
@adamgalway-r7 adamgalway-r7 merged commit 208e599 into rapid7:master Feb 7, 2020
3 checks passed
3 checks passed
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.