Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix args when directly opening a channel #13069

Merged
merged 1 commit into from Mar 13, 2020

Conversation

@zeroSteiner
Copy link
Member

zeroSteiner commented Mar 12, 2020

This PR fixes the arguments when a channel is directly created instead of using Channel.create. The changes I made in #12984 added the response packet as an additional required argument. While most code paths use Channel.create to create their channels and this path was updated, paths which directly instantiated their desired class were missed. This fixes that allowing those channels to be created as well. This notably fixes the powershell_shell Meterpreter command from the powershell extension.

Verification

  • Get a native-Windows Meterpreter session on Windows
    • Test that the shell command works, showing that the process channel is created correct
    • Test the powershell_shell command works
    • Test that the play command works (use a .WAV file such as this example)
@timwr timwr self-assigned this Mar 13, 2020
@timwr timwr merged commit 1807461 into rapid7:master Mar 13, 2020
3 checks passed
3 checks passed
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@timwr

This comment has been minimized.

Copy link
Contributor

timwr commented Mar 13, 2020

Looks great, meterpreter > powershell_shell is working now. meterpreter > play data/sounds/default/excellent.wav was working before and after.
I wasn't able to to test meterpreter > mic_start because my "mac" doesn't have a microphone but the fix looks good.

@timwr

This comment has been minimized.

Copy link
Contributor

timwr commented Mar 13, 2020

Release Notes

Updates the Meterpreter powershell_shell command to fix a bug where an argument was missing when creating the channel class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.