Import correct password type from Metasploit DB #1568

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@averagesecurityguy
Contributor

averagesecurityguy commented Mar 9, 2013

The Metasploit XML file parser sets the :ptype option on
cred_data because that is the name of the XML tag. The
report_auth_info method is expecting an option of :type.
Since the :type option is not given, all imported passwords
are of type "password". I modified the XML parser to set the
:type option instead of the :ptype option.

averagesecurityguy added some commits Mar 9, 2013

Import correct password type in Metasploit DB.
The Metasploit XML file parser sets the :ptype option on
cred_data because that is the name of the XML tag. The
report_auth_info method is expecting an option of :type.
Since the :type option is not given, all imported passwords
are of type "password". I modified the XML parser to set the
:type option instead of the :ptype option.
Use KnownPlainText service to crack passwords.
Uses the KnownPlainText.co password cracking service to crack
weak Windows passwords. Requires a working KnownPlainText client,
including a valid license key.
@averagesecurityguy

This comment has been minimized.

Show comment Hide comment
@averagesecurityguy

averagesecurityguy Mar 14, 2013

Contributor

Any thoughts on when this might get pulled in? If the problem is with the KPT module I can remove that from the pull request and host it on my own site.

Contributor

averagesecurityguy commented Mar 14, 2013

Any thoughts on when this might get pulled in? If the problem is with the KPT module I can remove that from the pull request and host it on my own site.

@jlee-r7

This comment has been minimized.

Show comment Hide comment
@jlee-r7

jlee-r7 Mar 14, 2013

Contributor

There are two things here. I didn't look too hard at the module because it belongs in its own pull request, but the special-casing of :ptype vs :type should probably be handled in report_auth_info instead of here.

Contributor

jlee-r7 commented Mar 14, 2013

There are two things here. I didn't look too hard at the module because it belongs in its own pull request, but the special-casing of :ptype vs :type should probably be handled in report_auth_info instead of here.

@averagesecurityguy

This comment has been minimized.

Show comment Hide comment
@averagesecurityguy

averagesecurityguy Mar 14, 2013

Contributor

I'll withdraw the request and send a separate request for the module only.

On Thu, Mar 14, 2013 at 3:30 PM, jlee-r7 notifications@github.com wrote:

There are two things here. I didn't look too hard at the module because it
belongs in its own pull request, but the special-casing of :ptype vs :typeshould probably be handled in
report_auth_info instead of here.


Reply to this email directly or view it on GitHubhttps://github.com/rapid7/metasploit-framework/pull/1568#issuecomment-14923989
.

Stephen Haywood
Information Security Consultant
CISSP, GSEC, OSCP
T: @averagesecguy
W: averagesecurityguy.info

Contributor

averagesecurityguy commented Mar 14, 2013

I'll withdraw the request and send a separate request for the module only.

On Thu, Mar 14, 2013 at 3:30 PM, jlee-r7 notifications@github.com wrote:

There are two things here. I didn't look too hard at the module because it
belongs in its own pull request, but the special-casing of :ptype vs :typeshould probably be handled in
report_auth_info instead of here.


Reply to this email directly or view it on GitHubhttps://github.com/rapid7/metasploit-framework/pull/1568#issuecomment-14923989
.

Stephen Haywood
Information Security Consultant
CISSP, GSEC, OSCP
T: @averagesecguy
W: averagesecurityguy.info

@jvazquez-r7

This comment has been minimized.

Show comment Hide comment
@jvazquez-r7

jvazquez-r7 Mar 14, 2013

Contributor

About the module, after commenting with @todb-r7 we think it's more appropriate to distribute by yourself, maybe with instructions about how to get it in ~/.msf4/modules/auxiliary

Really thanks!

Contributor

jvazquez-r7 commented Mar 14, 2013

About the module, after commenting with @todb-r7 we think it's more appropriate to distribute by yourself, maybe with instructions about how to get it in ~/.msf4/modules/auxiliary

Really thanks!

@averagesecurityguy

This comment has been minimized.

Show comment Hide comment
@averagesecurityguy

averagesecurityguy Mar 14, 2013

Contributor

Appreciate it guys. Will do.

On Thu, Mar 14, 2013 at 5:42 PM, Juan Vazquez notifications@github.comwrote:

About the module, after commenting with @todb-r7https://github.com/todb-r7we think it's more appropriate to distribute by yourself, maybe with
instructions about how to get it in ~/.msf4/modules/auxiliary

Really thanks!


Reply to this email directly or view it on GitHubhttps://github.com/rapid7/metasploit-framework/pull/1568#issuecomment-14931154
.

Stephen Haywood
Information Security Consultant
CISSP, GSEC, OSCP
T: @averagesecguy
W: averagesecurityguy.info

Contributor

averagesecurityguy commented Mar 14, 2013

Appreciate it guys. Will do.

On Thu, Mar 14, 2013 at 5:42 PM, Juan Vazquez notifications@github.comwrote:

About the module, after commenting with @todb-r7https://github.com/todb-r7we think it's more appropriate to distribute by yourself, maybe with
instructions about how to get it in ~/.msf4/modules/auxiliary

Really thanks!


Reply to this email directly or view it on GitHubhttps://github.com/rapid7/metasploit-framework/pull/1568#issuecomment-14931154
.

Stephen Haywood
Information Security Consultant
CISSP, GSEC, OSCP
T: @averagesecguy
W: averagesecurityguy.info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment