Update zerologon error handling to output invalid computer name details #16858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
force-pushed
the
update-zerologon-error-handling
branch
from
a32fc72
to
94f25bd
Compare
adfoster-r7
force-pushed
the
update-zerologon-error-handling
branch
from
94f25bd
to
8253e99
Compare
smcintyre-r7
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
That's a pretty nice improvement.
msf6 auxiliary(admin/dcerpc/cve_2020_1472_zerologon) > run
[*] Running module against 192.168.159.96
[*] 192.168.159.96: - Connecting to the endpoint mapper service...
[*] 192.168.159.96:49669 - Binding to 12345678-1234-abcd-ef00-01234567cffb:1.0@ncacn_ip_tcp:192.168.159.96[49669] ...
[*] 192.168.159.96:49669 - Bound to 12345678-1234-abcd-ef00-01234567cffb:1.0@ncacn_ip_tcp:192.168.159.96[49669] ...
[+] 192.168.159.96:49669 - Successfully authenticated
[+] 192.168.159.96:49669 - Successfully set the machine account (WIN-3MSP8K2LCGC$) password to: aad3b435b51404eeaad3b435b51404ee:31d6cfe0d16ae931b73c59d7e0c089c0 (empty)
[*] Auxiliary module execution completed
msf6 auxiliary(admin/dcerpc/cve_2020_1472_zerologon) > run NBNAME=FOOOOOO
[*] Running module against 192.168.159.96
[*] 192.168.159.96: - Connecting to the endpoint mapper service...
[*] 192.168.159.96:49669 - Binding to 12345678-1234-abcd-ef00-01234567cffb:1.0@ncacn_ip_tcp:192.168.159.96[49669] ...
[*] 192.168.159.96:49669 - Bound to 12345678-1234-abcd-ef00-01234567cffb:1.0@ncacn_ip_tcp:192.168.159.96[49669] ...
[-] 192.168.159.96:49669 - Auxiliary aborted due to failure: unexpected-reply: (0xc0000122) STATUS_INVALID_COMPUTER_NAME: Indicates a name that was specified as a remote computer name is syntactically invalid.
[*] Auxiliary module execution completed
msf6 auxiliary(admin/dcerpc/cve_2020_1472_zerologon) >
Release NotesThis updates zerologon to have better error handling in the check method. This will cause the error from an invalid NetBIOS name to be reported with a meanful message. |
bwatters-r7
added
the
rn-modules
smcintyre-r7
added
rn-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Zerologon module to clearly indicate to the user when the specified remote computer name is invalid
Before
There is a long pause before saying the module didn't work, without any clear indication why:
After
The module immediately prompts the user that the computer name is most likely wrong:
Verification
msfconsoleuse admin/dcerpc/cve_2020_1472_zerologon