Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed the credential parsing and made output consistent #2878
So in the previous refactor, we made the dedicated method to parse
The only way I can see around this (maybe because I'm a ruby newb) would
Hi @mandreko, we got a vulnerable device for testing, and I was able to check changes successfully :)
So if you don't mind I'm going to land this pull request with my review included at the moment. If later you figure there is anything wrong with my changes, feel free to make new pull request or just ping me and we can fix! Landing! Thanks a lot for keep reviewing it, you rock!