TFTP::Client retransmit lost data blocks on upload #5518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retransmit data blocks until we receieve a matching ACK.
| else | ||
| if block_given? | ||
| yield "Got an unexpected response: Code:%d, Type:%d, Message:'%s'. Aborting." % [code, type, msg] | ||
| while true |
|
I ran into a lot of trouble just using the tftp client with or without this change. It doesn't work on OS X (UDP Rex socket issues). It indicates success when a real TFTP server sends an error packet. It indicates failure when the Rex TFTP server sends an ACK. I'm going to need to understand how this works better to make it fully functional again. |
|
I've been sitting on a few fixes for this in the mean time that might as well land. The main issue was the retries will spin 100% cpu if the remote server is not actually responding, so I added a max retry before giving up. |
bcook-r7
pushed a commit
that referenced
this pull request
Sep 24, 2015
|
Thanks, #6001 sums up the remaining things to fix with TFTP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retransmit data blocks until we receieve a matching ACK.